Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending NMI #384

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Add support for sending NMI #384

merged 1 commit into from
Mar 11, 2024

Conversation

coffeefreak101
Copy link
Collaborator

What does this PR implement/change/remove?

Support for sending an NMI has been added to ipmi, redfish, redfishwrapper, and all providers that use the redfishwrapper.

Checklist

  • Tests added
  • Similar commits squashed

Description for changelog/release notes

Adds support for sending an NMI to ipmi, redfish, redfishwrapper, and all providers that use the redfishwrapper.

@coffeefreak101 coffeefreak101 requested a review from joelrebel March 7, 2024 23:42
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 43.83%. Comparing base (7a00485) to head (8dc2d91).

Files Patch % Lines
internal/redfishwrapper/power.go 0.00% 10 Missing ⚠️
client.go 0.00% 6 Missing ⚠️
providers/dell/idrac.go 0.00% 2 Missing ⚠️
providers/ipmitool/ipmitool.go 0.00% 2 Missing ⚠️
providers/redfish/redfish.go 0.00% 2 Missing ⚠️
providers/supermicro/supermicro.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   43.73%   43.83%   +0.09%     
==========================================
  Files          60       61       +1     
  Lines        5316     5368      +52     
==========================================
+ Hits         2325     2353      +28     
- Misses       2771     2795      +24     
  Partials      220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coffeefreak101 coffeefreak101 force-pushed the fs-740-add-send-nmi-support branch 2 times, most recently from 38d1dc3 to 41bb750 Compare March 8, 2024 01:03
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor suggestion

internal/redfishwrapper/power.go Show resolved Hide resolved
Support for sending an NMI has been added to ipmi, redfish,
redfishwrapper, and all providers that use the redfishwrapper.
@coffeefreak101 coffeefreak101 force-pushed the fs-740-add-send-nmi-support branch from 41bb750 to 8dc2d91 Compare March 8, 2024 15:03
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 5b958a7 into main Mar 11, 2024
9 checks passed
@mergify mergify bot deleted the fs-740-add-send-nmi-support branch March 11, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants